Skip to content

Deprecate type setting CPU/MEM and tls setting IBMMQ #6698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Deprecate type setting CPU/MEM and tls setting IBMMQ #6698

wants to merge 8 commits into from

Conversation

rickbrouwer
Copy link
Contributor

@rickbrouwer rickbrouwer commented Apr 8, 2025 •
edited
Loading

Remove Prometheus webhook prommetrics deprecations
Remove the type setting in CPU Memory scaler
Remove tls setting in the IBM MQ scaler
Update typed_config conform governance deprecations

Checklist

Fixes #6348 #6095
Docs: kedacore/keda-docs#1564
Relates to #2844

@rickbrouwer rickbrouwer requested a review from a team as a code owner April 8, 2025 14:44
@rickbrouwer
Update changelog
21fd0dc 
Signed-off-by: Rick Brouwer <[email protected]>
@rickbrouwer rickbrouwer changed the title Deprecations Deprecate type setting CPU/MEM and tls setting IBMMQ Apr 8, 2025
@rickbrouwer rickbrouwer marked this pull request as draft April 8, 2025 20:01
@rickbrouwer rickbrouwer mentioned this pull request Apr 9, 2025
Open
1 task
@rickbrouwer rickbrouwer marked this pull request as ready for review April 9, 2025 13:25
JorTurFer
JorTurFer reviewed Apr 21, 2025
View reviewed changes
JorTurFer
JorTurFer reviewed Apr 21, 2025
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! just some nits inline :)

@rickbrouwer rickbrouwer force-pushed the deprecations branch 2 times, most recently from f650e50 to 8ea97cd Compare April 22, 2025 05:49
@rickbrouwer
Update
1be0751 
Signed-off-by: Rick Brouwer <[email protected]>
JorTurFer
JorTurFer approved these changes Apr 26, 2025
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rickbrouwer @JorTurFer